fix(create-svelte): add hint when scaffolding#9318
Merged
dummdidumm merged 3 commits intosveltejs:masterfrom Mar 5, 2023
Merged
fix(create-svelte): add hint when scaffolding#9318dummdidumm merged 3 commits intosveltejs:masterfrom
dummdidumm merged 3 commits intosveltejs:masterfrom
Conversation
theetrain
force-pushed
the
fix/create-tutorial
branch
from
6283255 to
87b2794
Compare
Rich-Harris
reviewed
Mar 5, 2023
packages/create-svelte/bin.js
Outdated
| features: () => | ||
| p.multiselect({ | ||
| message: 'Select additional options', | ||
| message: 'Select additional options (use arrow keys to navigate and SPACE to toggle options)', |
Member
There was a problem hiding this comment.
Maybe make it a little shorter, so that it's less likely to break onto two lines?
Suggested change
| message: 'Select additional options (use arrow keys to navigate and SPACE to toggle options)', | |
| message: 'Select additional options (use arrow keys/space bar)', |
Contributor
Author
There was a problem hiding this comment.
Sounds good to me 👍
dummdidumm
approved these changes
Mar 5, 2023
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relates to #9317
A number of folks on Discord have been asking how to toggle options in the new 'Select additional options' step when running
npm create svelte@latest. This change aims to provide a hint for this lesser-known prompt experience.Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
Tests
pnpm testand lint the project withpnpm lintandpnpm checkChangesets
pnpm changesetand following the prompts. Changesets that add features should beminorand those that fix bugs should bepatch. Please prefix changeset messages withfeat:,fix:, orchore:.